search

learnweb / moodle-mod_collabora

:memo: :globe_with_meridians: An activity for live document editing in Moodle, powered by Collabora Online
GNU General Public License v3.0
9 stars 8 forks source link

Dynamic server branding support #20

Open Ashod opened 4 years ago

Ashod commented 4 years ago

The Online server product name is now dynamically pulled from the server, once a valid URL is provided. After the initial discovery of the server capabilities, the product-name is cached.

However we allow for changing the server (or, upon updating the server the product name may have been changed) by clearing the cache from the plugin settings page. Simply loading the settings page will invalidate the cache, if a URL is already set and is valid, and will pull the new name.

The relevant strings displayed in the UI have been updated to use the product name provided by the server with proper fallback.

codecov-commenter commented 4 years ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 13.18%. Comparing base (fc22536) to head (7afd352). Report is 59 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #20 +/- ## ============================================ - Coverage 14.02% 13.18% -0.84% - Complexity 137 152 +15 ============================================ Files 17 17 Lines 699 743 +44 ============================================ Hits 98 98 - Misses 601 645 +44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mwuttke commented 4 years ago

@grabs please could you review this patch? Michael