learnweb / moodle-mod_moodleoverflow

:speech_balloon: Non-linear discussion module for Q&A forums
GNU General Public License v3.0
12 stars 22 forks source link

Problems following upgrade #190

Closed pejhab closed 1 week ago

pejhab commented 1 month ago

Hello,

I have recently upgraded to Moodleoverflow v4.4-r1 and now video filters have stopped working (Generico and generic Moodle video embed). I am further looking into this.

Have you had similar reports?

Regards,

P.H.

pejhab commented 1 month ago

To clarify, the Generico filter works fine if I use it to embed a video in a post on a Moodle standard forum, but it fails on Moodle overflow.

STARNDARD FORUM:

image

OVERFLOW:

image

My Moodle version: 4.1+ (Build: 20221209)

pejhab commented 1 month ago

I have also noticed that glossary linking no longer works on Moodleoverflow.

NinaHerrmann commented 1 month ago

@TamaroWalter Could you please test that?

pejhab commented 1 month ago

Glossary "auto-linking", that is.

pejhab commented 1 month ago

Could you please confirm this as a bug? All our videos on all our Moodleoverflow forums have stopped working.

NinaHerrmann commented 1 month ago

Please remember that this is not our fulltime job. @TamaroWalter will probably look into that tomorrow.

TamaroWalter commented 1 month ago

Hello @pejhab, thank you for reporting an issue. I tried to reproduce your problem on my system and indeed, there is a bug while formating embedded videos in Moodleoverflow. I am on this issue!

TamaroWalter commented 1 month ago

Hello @pejhab, I committed a fix in #191 and embedded videos are now working on my moodle systems (M4.4 and M4.1). If you want, you can add the changes to your system and test if it works too. If you do, please report it so I can either continue searching for the bug or add the changes to the productive system. Regards Tamaro

pejhab commented 1 month ago

Hello, I replaced the two files with the modified versions and Generico video embedding, standard video embedding, and glossary auto-linking all seem to be working properly again. Thanks for your time and effort!

Laur0r commented 1 week ago

Hello, these problems should be fixed with v4.4-r3.