sevenseas-gists commented 4 years ago

closes #23 Provides basic search function via integration into the global search api

codecov-commenter commented 4 years ago

Codecov Report

Merging #62 into master will increase coverage by 2.79%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
+ Coverage     18.08%   20.87%   +2.79%     
- Complexity      453      485      +32     
============================================
  Files            43       44       +1     
  Lines          3982     4125     +143     
============================================
+ Hits            720      861     +141     
- Misses         3262     3264       +2

Impacted Files	Coverage Δ	Complexity Δ
classes/search/moodleoverflowposts.php	`0.00% <0.00%> (ø)`	`30.00 <30.00> (?)`
classes/privacy/provider.php	`81.62% <0.00%> (-0.46%)`	`16.00% <0.00%> (ø%)`
classes/privacy/data_export_helper.php	`98.33% <0.00%> (+0.05%)`	`42.00% <0.00%> (+2.00%)`
locallib.php	`9.55% <0.00%> (+3.02%)`	`0.00% <0.00%> (ø%)`
lib.php	`7.49% <0.00%> (+4.91%)`	`0.00% <0.00%> (ø%)`
classes/ratings.php	`35.20% <0.00%> (+31.20%)`	`91.00% <0.00%> (ø%)`
classes/event/rating_created.php	`50.00% <0.00%> (+50.00%)`	`3.00% <0.00%> (ø%)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7640c4...7efdd7a. Read the comment docs.

Laur0r commented 4 years ago

Hey could you leave detailed instructions on how to test the search function?

NinaHerrmann commented 3 years ago

@rtschu ?

codecov-io commented 3 years ago

Codecov Report

Merging #62 (7efdd7a) into master (a297dd5) will decrease coverage by 0.64%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
- Coverage     21.51%   20.87%   -0.65%     
- Complexity      455      485      +30     
============================================
  Files            43       44       +1     
  Lines          4001     4125     +124     
============================================
  Hits            861      861              
- Misses         3140     3264     +124

Impacted Files	Coverage Δ	Complexity Δ
classes/search/moodleoverflowposts.php	`0.00% <0.00%> (ø)`	`30.00 <30.00> (?)`
lib.php	`7.49% <0.00%> (+0.01%)`	`0.00% <0.00%> (ø%)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a297dd5...b83c57c. Read the comment docs.

NinaHerrmann commented 3 years ago

Hey Robin, nice, you are working on it :slightly_smiling_face: could you please check the warning of the codechecker before we start to review the pull request? Some of them might be not so so important but most of them are best practices that you should have a look at :slightly_smiling_face: Thanks in advance!

sevenseas-gists commented 3 years ago

absolutely, I meant to change the title to WIP until travis is ok have added that now :)

mojaedukacja commented 3 years ago

Global search works good only with full words, but not with word fragments (nice to have).

Thanks for your work.

learnweb / moodle-mod_moodleoverflow

WIP: integrated moodleoverflow into the global search #62

Codecov Report

Codecov Report