search

learnweb / moodle-tool_lifecycle

:recycle: Extensible Moodle plugin for managing course life cycles, e.g., deprovisioning
GNU General Public License v3.0
20 stars 32 forks source link

Add the possibility of editing steps and triggers after workflow activation #134

Closed justusdieckmann closed 2 years ago

justusdieckmann commented 2 years ago

Depends on the subplugin, already implemented for all in-repo steps and startdatedelay trigger

NinaHerrmann commented 2 years ago

Thanks @justusdieckmann I will post issues as I discover them. The first thing which I saw was that the warning message when adjusting workflows might be misleading. This should be changed to sth. like be careful dependent on the step/trigger adjustments can be made. image

justusdieckmann commented 2 years ago

I added the trigger warning to the normal warning message, however I think highlighting not editable settings could be a bit annoying, because depending how to highlight the settings, I do not really see a good way to do this in the common step/trigger handling, but instead I believe it must probably be done per subplugin in the extend_add_instance_form_definition methods.

The commit is currently failing CI, this should be fixed after merging #136. If preferred, I could provide a fix for this as a seperate PR.

Laur0r commented 2 years ago

Thank you @justusdieckmann!