search

learnyouanelm / learnyouanelm.github.io

“Learn You an Elm!”, based on LYAH by Miran Lipovača
http://learnyouanelm.github.io/
93 stars 16 forks source link

Typo - Chapter Making Our Own Types #49

Closed tporcham closed 4 years ago

tporcham commented 4 years ago

Hi,

I think there is a little typo in chapter "Making Our Own Types".

A type is defined as type Shape = Circle Float Float Float | Rectangle Float Float Float Float

The type signature is given as:

`> Circle

: Float -> Float -> Float -> Shape > Rectangle : Float -> Float -> Float -> Shape` I think a Float is missing for the Rectangle constructor, so it should be: `> Rectangle : Float -> Float -> Float -> Float -> Shape`
ebenpack commented 4 years ago

Yes, you're absolutely right! Would you like to make a PR for this?

tporcham commented 4 years ago

Created a pull request: https://github.com/learnyouanelm/learnyouanelm.github.io/pull/50