search

leather-io / desktop

Manage STX tokens and Stacking
https://leather.io/
191 stars 71 forks source link

Fix analytics in production #1117

Closed markmhendrickson closed 1 year ago

markmhendrickson commented 1 year ago

For some reason, events are not getting sent to Segment in general for the desktop wallet in production; however, they appear to work in dev and staging. This consists of investigating and resolving why they're broken.

edu-stx commented 1 year ago

After some investigating, I couldn't find anything obvious in the code that required fixing. It may just be a misconfigured github secret (I don't have access to them). @markmhx do you have access? the key is in https://app.segment.com/hirosystems/sources/stacks-desktop-wallet/overview, or can do it myself if granted access.

Just in case, I've updated the segment lib in https://github.com/hirosystems/stacks-wallet/pull/1134 , which itself is waiting for https://github.com/hirosystems/stacks-wallet/pull/1133 to be merged first.

edu-stx commented 1 year ago

I'm prepared to merge PR with the updated Segment lib. To be sure we've covered all cases, we should confirm that Segment's write key, defined in GH secrets as SEGMENT_WRITE_KEY, matches is set to the prod desktop wallet.

I don't have access to secrets. @kyranjamie @markmhx is this something you could take a look at or grant me access to do myself?

kyranjamie commented 1 year ago

Done @edu-stx

edu-stx commented 1 year ago

@markmhx seeing events show up again, seems to be fixed now.