leather-io / desktop

Manage STX tokens and Stacking
https://leather.io/
191 stars 71 forks source link

[4.6.1] Update hiro.so wallet download link to latest version (automatically) #1130

Closed aamjad2001 closed 1 year ago

aamjad2001 commented 1 year ago

Bug found testing Hiro Wallet build undefined, 4.6.1. I have updated to desktop version 4.6.1 but even after update its still showing "Update available" on the top

314159265359879 commented 1 year ago

Thanks for reporting @aamjad2001 we'll want to fix this so the "update available" message is only displayed when there is a new version available.

edu-stx commented 1 year ago

Thanks for the report @aamjad2001, are you having the same issue with the latest release? I'm unable to reproduce.

314159265359879 commented 1 year ago

Thanks for the report @aamjad2001, are you having the same issue with the latest release? I'm unable to reproduce.

Thanks to cubricray on Telegram, I now see the issue isn't with the wallet. The hiro.so webpage is directing to 4.6.1 even now. We'll need to update that. Should that be automatic with a release?

image

markmhendrickson commented 1 year ago

Let's hold off on fixing this until https://github.com/hirosystems/stacks-wallet/issues/1139 is resolved since the latest version has a critical Ledger bug coincidentally.

314159265359879 commented 1 year ago

1139 is resolved, good time for this one. The Hiro.so site is still pointing to 4.6.1.

markmhendrickson commented 1 year ago

Let's resolve https://github.com/hirosystems/stacks-wallet/issues/1149 as well before tackling this one

markmhendrickson commented 1 year ago

We can move forward with the website fix here now since we've discovered that #1149 is due to an API-borne issue, not wallet-borne.

tprebz commented 1 year ago

The website is fixed, and the script to auto-update the download links based on latest release is alive once again.