leather-io / desktop

Manage STX tokens and Stacking
https://leather.io/
191 stars 71 forks source link

Support comma delimiters in amount field of send form #1152

Open markmhendrickson opened 1 year ago

markmhendrickson commented 1 year ago
Screenshot 2023-01-15 at 14 17 52
kyranjamie commented 1 year ago

I'd hold off doing this until we localise the wallet properly. To many, this is 5.210 which adds an ambiguity that isn't there with no delimiter at all.

markmhendrickson commented 1 year ago

Are there English locales that treat the comma as a decimal? If so, I'd agree let's wait. Though if not, it seems consistent with the default language?

314159265359879 commented 1 year ago

I would prefer not using delimiting like this, it just leads to confusion and mistakes. Only use . and , as decimal mark

If you want to improve readability use space for delimiting.