leather-io / desktop

Manage STX tokens and Stacking
https://leather.io/
192 stars 71 forks source link

Fix display of pending transactions in activity #1173

Closed markmhendrickson closed 1 year ago

markmhendrickson commented 1 year ago

They seem not to appear while pending, either for delegation transactions or regular STX sends:

First

Screenshot 2023-03-30 at 09 36 27 Screenshot 2023-03-30 at 09 28 17

Then

Screenshot 2023-03-30 at 09 48 49 Screenshot 2023-03-30 at 09 48 45
314159265359879 commented 1 year ago

@markmhx as Hero-Gamer pointed out in #1161 otherwise the user might attempt again creating unnecessary duplicate tx. we have definitely been seeing that. Perhaps a good reason to handle this as a P2 because it adds additional issues when users do not realize prior transactions are successfully transmitted.

markmhendrickson commented 1 year ago

@kyranjamie reminder about this one while you're in the desktop code 🙏

kyranjamie commented 1 year ago

@markmhx @314159265359879 Are we sure this is a problem still?

image

It could've been that there were a temp issue with the mempool?

markmhendrickson commented 1 year ago

Mind sending a transaction on mainnet to test / confirm? If you need me to, I can also QA it again.

kyranjamie commented 1 year ago

This also worked too

image
markmhendrickson commented 1 year ago

This worked for me now too in my testing 🤷