Reconsider Firefox app bundling

leather-io / extension

Leather browser extension

https://leather.io

MIT License

294 stars 141 forks source link

Reconsider Firefox app bundling #1546

Closed kyranjamie closed 8 months ago

kyranjamie commented 3 years ago

App developers themselves may well be working with the production wallet build. We want them to be able to debug issues with their app, or the wallet, as easily as possible.

Currently we minify/obfuscate the Firefox production build. See these two examples of errors thrown when you omit the appIcon prop from the object passed to showConnect.

We should disable the minification altogether, or find another way to retain rich error information.

LNow commented 3 years ago

Although I can understand reasons behind minifing code, the way it has been done can drive dapps developers nuts.

All errors should be easily accessible no matter which browser we use.