leather-io / extension

Leather browser extension
https://leather.io
MIT License
303 stars 142 forks source link

Display helpful error when incompatible parameters set for transaction signing #1794

Open radicleart opened 3 years ago

radicleart commented 3 years ago

Web Wallet v2.19.3 Found in Chrome

Trying to run transactions on loopbomb.io, stxnft.com and thisisnumberone.com and found the web wallet opening in "white screen mode" with the following error in console.

Logged into the app and wallet

TypeError: Cannot read properties of undefined (reading 'transaction') at Object.read (index.js:64756) at readAtomState (index.js:119027) at index.js:119029 at Object.read (index.js:64791) at readAtomState (index.js:119027) at index.js:119029 at Object.read (index.js:64604) at readAtomState (index.js:119027) at Object.readAtom [as r] (index.js:119078) at index.js:119507 Ni @ index.js:135325

Screenshot 2021-10-10 at 15 38 55
radicleart commented 3 years ago

Just realised the error is down to the UI being ahead of the contract - there are extra params in the call not in the old contract.

Will leave this open as improvement for the error handling.

markmhendrickson commented 3 years ago

Thanks for the report! I agree, let's leave this open to improve error handling here.

radicleart commented 3 years ago

Just realised there is another scenario where this happens..

If you are logged into an app but the wallet is locked / requires the password. I think after I restart chrome i get into this situation. Running a transaction in the app leads to the same white web wallet screen.

fbwoolf commented 3 years ago

Just realised there is another scenario where this happens..

If you are logged into an app but the wallet is locked / requires the password. I think after I restart chrome i get into this situation. Running a transaction in the app leads to the same white web wallet screen.

I think what you are describing was fixed with this PR but has been released yet: https://github.com/blockstack/stacks-wallet-web/pull/1785. See issue #1782