search

leather-io / extension

Leather browser extension
https://leather.io
MIT License
295 stars 141 forks source link

Audit exchanges listed on fund page #2920

Open kyranjamie opened 1 year ago

kyranjamie commented 1 year ago

@hugocaillard pointed out that some exchanges are missing, and Coinbase says US only when it's available elsewhere.

@markmhx how can we make sure this list remains current / who should take ownership of maintaining the list?

markmhendrickson commented 1 year ago

This could be something that @314159265359879 helps us maintain. @kyranjamie can you capture instructions in Notion somewhere on how to update these listings and share with him?

kyranjamie commented 1 year ago

The instructions on how to update the config are captured in the repo https://github.com/hirosystems/stacks-wallet-web/blob/dev/config/wallet-config.md

@314159265359879 either we can maintain a list in Notion, and have developers update, or if you're comfortable doing so, committing updates to the json file directly in the repo. Happy to jump on a call to figure out the best way to work together on this

314159265359879 commented 1 year ago

I am happy to help maintain this.

Do we want or need this list to be exhaustive? or could it suffice to add a link at the end which shows additional markets that have STX available? for example: https://coinmarketcap.com/currencies/stacks/markets/ and/or https://www.coingecko.com/en/coins/stacks#markets

We recently removed Okcoin from the list because they no longer supported the "fast checkout" it does however still have STX listed and allows withdraws. Should it be added to the list again?

If we want to limit it to listing the bigger exchanges, Kraken added STX in October, they should be in the list in that case?

Here is a similar approach taken by Stacks.co "Get STX" page here they have a listed a lot of the exchanges available, with some features, and also link to coingecko.com to "find all exchanges and pairs".

fbwoolf commented 1 year ago

The implementation isn't really as simple as just editing the config.

markmhendrickson commented 1 year ago

The implementation isn't really as simple as just editing the config.

Mind indicating the other steps involved here?

Do we want or need this list to be exhaustive? or could it suffice to add a link at the end which shows additional markets that have STX available? for example: https://coinmarketcap.com/currencies/stacks/markets/ and/or https://www.coingecko.com/en/coins/stacks#markets

It's not necessary that we keep a 100% complete list of STX-supporting exchanges at all times. Rather, we aim to provide as many of them as possible, as they come onto our radar.

I suppose we could add links to market aggregators like CoinMarketCap as well, though the page wasn't designed with them in mind per se.

We recently removed Okcoin from the list because they no longer supported the "fast checkout" it does however still have STX listed and allows withdraws. Should it be added to the list again?

Good catch, we should indeed list them again but as a generic exchange i.e. with a link to the related FAQ.

If we want to limit it to listing the bigger exchanges, Kraken added STX in October, they should be in the list in that case?

Kraken is a good candidate to add, not that we need to limit ourselves to bigger ones. Small ones are good, too.

markmhendrickson commented 1 year ago

@314159265359879 we discussed this as a team and it seems easiest if you open up specific issues for the addition or removal requests you'd like to make, and the devs can take care of implementing those changes.

If they are addition requests, please include the name of the exchange as well as an image and description copy to use per the standard format:

image
314159265359879 commented 1 year ago

I have made additional items per change. I will revisit in about a month.