leather-io / extension

Leather browser extension
https://leather.io
MIT License
305 stars 143 forks source link

Render images encoded inside JSON e.g. verified credentials #3459

Open markmhendrickson opened 1 year ago

markmhendrickson commented 1 year ago

It seems we'd essentially have to detect certain JSON attributes (e.g. under @context) then pull out standardized image attributes for display.

e.g. for "verified credentials" https://ordinalswallet.com/inscription/75d6ae0a88d1c59969f86998413b3fd620ba885a1e904c5a01078d488cf0158di0

RagnarLifthrasir commented 1 year ago

Is this relevant? https://github.com/casey/ord/issues/1859#issue-1603896380

Psifour commented 1 year ago

There are concerns with this format/structure in that it is storing binary blobs as base64. This results in them taking up a minimum of 33% more space (6 bits encoded in each byte). It suffers from the same problem as many other toys/solutions currently in that they are trying to use JSON (for convenience) in places where it makes little sense.

If Hiro Wallet chooses to integrate these it may quickly lead to community expectations for the mass implementation of poorly designed 'standards' that, in my experience, will lead to development hell. With that said, there is a marketing play to be had by being the wallet that supports all these toys.

RagnarLifthrasir commented 1 year ago

Ordinal inscriptions take up space in the blockchain. The majority of Inscriptions are "toys". The Ordinal theory is a standard.

The above format structure (or something that accomplishes the same purpose) has utility. Wallets supporting it are meeting Bitcoiners' demand for Ordinal tools.

It's essential to have the most efficient and safe designs and implementations. But let's remember there are no gatekeepers in Bitcoin or Ordinals. No one decides what others should value.