leather-io / extension

Leather browser extension
https://leather.io
MIT License
293 stars 140 forks source link

Add `OP_RETURN` field to sendTransfer method #3976

Open mefrem opened 1 year ago

mefrem commented 1 year ago

Currently, in order to pass data to a Bitcoin transaction's OP_RETURN field, front-end devs have to construct a PSBT and use the PSBT API. Can this method be extended to include fields for OP_RETURN (for instance, for including the Hiro Wallet authenticated Stacks address so that it exists on-Bitcoin-chain)?

cc: @kenrogers

markmhendrickson commented 1 year ago

We've been discussing this as a team and erring towards keeping the sendTransfer method you've referenced simple (with the idea that PSBTs are best for more advanced use cases, since by nature they provide a ton of extensibility). However, there's certainly a trade-off here to requiring users to construct PSBTs as you've indicated.

Would it be sufficiently helpful if we provided guidance on how to construct PSBTs, especially ones with OP_RETURN data?

Iheff commented 1 year ago

I'm not in this conversation, but to me - Yes it would defintily have been useful to see a full end to end example of psbts: I've been asking for this elsewhere and was asked to instead provide example of how I would do it without hiro at all. Im kinda there now anyway via trail and error.... however still riding into some gochyas arround legacy addresses which I am asking about in your discord.

kenrogers commented 1 year ago

@markmhx that would be great and I think would sufficiently solve the problem.

kyranjamie commented 1 month ago

Speaking with some external parties, this is a common and quite useful use-case. As it's often used as a memo, of sorts, it seems reasonable sendTransfer would include this ability.