search

leather-io / extension

Leather browser extension
https://leather.io
MIT License
305 stars 143 forks source link

Add ability to use more inputs from Native SegWit balance when increase fees #4176

Open 314159265359879 opened 1 year ago

314159265359879 commented 1 year ago

The user who sent this transaction with a fee of 4.66 sats/vB was unable to increase the fee enough to be relevant with the "leftover" 331 sats. image

Currently, it is not possible to

  1. Use additional funds on the wallet to cover any increase in the fee, this is expected though.

  2. Some users may also be helped with the option to send with the same input but change the first output too. This transaction was emptying the wallet and sending to an Exchange. The user would have been happy to receive less on the exchange if it meant sending with a high enough fee to get it processed.

314159265359879 commented 1 year ago

Another example? 021b71e00661049c1d5172c2913a0bcbaf5e47b4ef40d073e94530bb8fadccab

The user gets this error (wallet tries to set a lower fee that initial?) when the user tries to increase the fee in this case.

image

image

314159265359879 commented 1 year ago

Another example also shown in 4168 The lowest minimum fee that day (6 days ago) was 8 sats/vB and the lowest average fee was also 8 sats/vB.

https://mempool.space/tx/0541c6866ae89b94f446ba1f6c1535e1ccf33ede4eeded9d99a528325a3d5639 image

Increasing the fee via the wallet on the transaction above will lead to this error:

image

DeeList commented 1 year ago

The user who sent this transaction with a fee of 14 sats/vB was unable to increase the fee due to an error.

https://mempool.space/tx/437eeedf1f28685d705d011d791e0a8c027466074ed2cea93a9f97ce125a1a26

tx inout

rbf error

314159265359879 commented 1 year ago

Should we be providing three options for users after clicking increase fee for bitcoin transactions?

a. Increase fee with current inputs without changing the amount to the receiving address (default) "Returning output" is used to cover increased fee, if there is none this option is grey/non-selectable. b. Increase fee by adding funds, no changes to any of the outputs. C. Increase fee by lowering the send amount to cover the increased fee. (Examples above withdraw to an exchange... it is fine when there is a bit less if that means it goes through right away).

markmhendrickson commented 1 year ago

Let's go with:

Use additional funds on the wallet to cover any increase in the fee, this is expected though.

DeeList commented 1 year ago

User reported 'Unable to increase fee' issue via support email, encountering a different error.

RBF error