search

leather-io / extension

Leather browser extension
https://leather.io
MIT License
304 stars 142 forks source link

Asset balances not loading... and connection issues API CORS errors #4546

Open 314159265359879 opened 11 months ago

314159265359879 commented 11 months ago

We have been seeing more of these errors lately. I wonder if it has something to do with the recent changes hiro.so made.

"request header field x-hiro-api-key is not allowed..." what does that mean? This is wallet version 6.16.1, should include the correct key, right @kyranjamie?

image This user reported that reinstalling the wallet cleared all the errors. Operating normally now.

Another user reported that reinstalling the wallet cleared up the blockstream API errors but not the Hiro.so ones, they saw this prior to reinstalling: Edit Nov 30th: The user contacted me again, it turned out that relogging didn't resolve the Hiro api problem but reinstalling the wallet did resolve the issue completely. Which is consistent with other users who reported this.

image

image

pete-watters commented 11 months ago

For these types of issues it would be great to gather:

Sometimes users can have plugins to block trackers that can interfere with things and testing in incognito mode is a good way to rule that out.

I tested the issue myself just now in Chrome and Brave and I cannot reproduce in v 6.16.1

markmhendrickson commented 11 months ago

Assigning to @314159265359879 for more contextual info

314159265359879 commented 11 months ago

Three more reports like this... balances not showing.

One of those users reported, errors in console looks similar to first user above: They tried with incognito mode but that had no effect. (Deelist below refers to this users.... this was resolved by reinstalling the extension)

image

DeeList commented 11 months ago

User reported a reinstall fixed the issue https://discord.com/channels/1075856098269089834/1075921953333968896/1177058194867105902

314159265359879 commented 11 months ago

Another report, Chrome user, version 6.16.1 of the Leather extension. Some of the errors displayed: image

markmhendrickson commented 11 months ago

I've asked Hiro for input on this key-related error

DeeList commented 11 months ago

whoabuddy.btc encountered this issue, requiring two reinstalls for successful TX. Also noted the problem persists post-reset, signing out, and signing back in with a different key.

Leather 6.17.0 Brave v1.60.125 (Chromium 119.0.6045.163) Linux Mint 20.3

https://discord.com/channels/1075856098269089834/1075920122314756166/1179547975706476655

From Hiro API: 'Access to fetch at 'https://api.hiro.so/extended/v1/address/ADDRESS/transactions_with_transfers?limit=50&unanchored=true' from origin 'chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj' has been blocked by CORS policy: Request header field x-leather-version is not allowed by Access-Control-Allow-Headers in preflight response.

GET https://api.hiro.so/extended/v1/address/ADDRESS/transactions_with_transfers?limit=50&unanchored=true net::ERR_FAILED'

From Blockstream API: 'Access to fetch at 'https://blockstream.info/api/address/ADDRESS/utxo' from origin 'chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: It does not have HTTP ok status.

GET https://blockstream.info/api/address/ADDRESS/utxo net::ERR_FAILED'

markmhendrickson commented 11 months ago

Hiro has bumped up our rate limits so we hopefully won't hit them again, at least as frequently.

I've also filed this related enhancement so the user can determine more clearly if rate limits are indeed causing this sort of buggy behavior: https://github.com/leather-wallet/extension/issues/4623

We're working with Hiro further to resolve rate-limiting-related issues. Let's return to this particular issue if we get more reports of the same console errors?