search

leather-io / extension

Leather browser extension
https://leather.io
MIT License
303 stars 142 forks source link

Ensure all HTML inscriptions appear in collectibles with previews #4809

Closed brandonmarshall-tm closed 7 months ago

brandonmarshall-tm commented 9 months ago

I just bought a cursed inscription through MagicEden to test our ability to store and display cursed inscriptions within Collections.

It does not show up in my Collectibles, and actually shows up as a UTXO "not" containing an inscription when using the "Retrieve BTC" feature [image attached below]

Inscription: https://ordinals.com/output/12192c9310e2a314fc31ecd26cf8997338da340b507f0f9e98c2c72e26d717c0:1

Transaction: https://mempool.space/tx/12192c9310e2a314fc31ecd26cf8997338da340b507f0f9e98c2c72e26d717c0

Screenshot 2024-01-15 at 11 28 41 AM

314159265359879 commented 9 months ago

I tested this one, looks like it does show up, it only took a couple of minutes after the transfer was confirmed on the blockchain. image

Perhaps the inscription above isn't displayed because of its source code? https://ordinals.com/inscription/ba20139b3fa0d0eb5f87e05708adae844c0e815db466ae89105169e47f5a7595i2

<script
  t="185,319,379,336,210,212,334,331,311,196,292,306"
  e="0"
  b="#c799ff"
  r="813000"
  src="/content/ea8fe5775eda290616d1fb42d0f1e65950ad4bc78485d3e6a89acde4476fa726i0"
></script>
brandonmarshall-tm commented 9 months ago

Ah yes, that would probably explain it. Though I wish we had a workaround for that, because it looks like more projects are using scripts in this way and Hiro doesn't seem to support them.

Another example of a non-cursed ordinal with script: https://ordinals.com/inscription/5aa1e09c67aef0afb5c9711627784acb6f329181452feda487afcc6bceffde65i302 https://ordinals.hiro.so/inscription/5aa1e09c67aef0afb5c9711627784acb6f329181452feda487afcc6bceffde65i302

314159265359879 commented 9 months ago

https://ord.link/49013928 This is one we are seeing displayed normally in the wallet it has this source code. So some script does run? ce6ac6ce0e3fab436216d079c5bf76d949314458c19c3e0eb65ccd6e306ce398i0

<script
  src="/content/d91650a911e27c5402ffd45893b17023e0ede8cb6912aa11fee0bbb264de2bfdi0"
  data-p="ae31b4cd9a38d68a933a2cfffb14660eb402e39a8069352ec65392b696691f9ei0,ss,4,100,1,d"
></script>
brandonmarshall-tm commented 9 months ago

Renamed the issue to be more in-line with what the actual problem is. Certain inscriptions containing Githubissues.

  • Githubissues is a development platform for aggregating issues.