search

leather-io / extension

Leather browser extension
https://leather.io
MIT License
289 stars 137 forks source link

Why can the dollar value of tokens in Leather deviate from SPOT price on an exchange? #5004

Open 314159265359879 opened 4 months ago

314159265359879 commented 4 months ago

image

I assume there can be temporary changes especially when markets are volatile and prices fluctuate a lot in a short period of time because it takes time for services to update their prices, and for the wallet to check and download the latest details.

In addition, we have one endpoint and the price there can deviate from the spot price on any given exchange or even another aggregator because they use different sources.

The dollar value in Leather is an approximation? should we be clearer on that?

If the service (to check dollar value) can't be reached larger deviations could be possible. Perhaps not showing the dollar value, or a loading error, would be better in that case. related to: https://github.com/leather-wallet/extension/issues/4787

kyranjamie commented 4 months ago

@mica000 @fabric-8 a lot of apps have disclaimers in the app when displaying fiat conversions. Maybe we need one too?

314159265359879 commented 4 months ago

Additional request, to cover value of LP tokens. https://www.notion.so/trustmachines/User-wants-to-see-dollar-value-of-liquidity-provider-LP-tokens-7df5ad95da50486393dd5bfa6ecada27?pvs=4