Increase fee dialog + `retrieve-taproot-funds` incorrect background

[pete-watters]

During testing I noticed that the increase fee dialog has an incorrect background:

I tried fixing it quickly but couldn't.

It's currently a routed dialog with routes for /increase-fee/stx and /increase-fee/btc.

@kyranjamie - what are your thoughts on changing this from being a routed dialog to a non routed dialog?

If you navigate directly to the URL the context of the transaction is not provided anyway

[pete-watters]

@markmhendrickson this relates to the issue you raised here .

In that scenario, increase fee hit an error and couldn't show the error page.

I fixed that but in testing it I found this other issue where the dialog has the incorrect BG

[kyranjamie]

@kyranjamie - what are your thoughts on changing this from being a routed dialog to a non routed dialog?

These are only called from the one place, so isn't it a case of just making sure the containing page has an <Outlet />? If necessary it can be a non-routed modal, but worry that could introduce stale state bugs, whereas the currently the state is ephemeral and passed with route state, I think?

[pete-watters]

OK thanks. I'll try fix it as routed dialogs. The STX increase fee doesn't get passed any state but maybe it should.

I'll investigate and fix properly

[pete-watters]

We have a similar issue with the retrieve-taproot-funds dialog which isn't showing the correct background page