leather-io / extension

Leather browser extension
https://leather.io
MIT License
293 stars 140 forks source link

Link to Explorer for testnet with api parameter #5123

Open markmhendrickson opened 5 months ago

markmhendrickson commented 5 months ago

It appears that the Nakamoto Testnet support on the Stacks Explorer requires an "api" parameter to work (and distinguish from the regular testnet).

E.g. https://explorer.hiro.so/txid/0x27f6b2de7ddff44a995202b2ef3bf1de5a8aeab7ca55370fac0cd1073be2f41f?chain=testnet&api=https://api.nakamoto.testnet.hiro.so

Without the parameter, the URL breaks / the transaction link leads to a 404

Let's add this parameter to our links from activity with whatever API value the user has configured for the Stacks network.

markmhendrickson commented 5 months ago

This is no longer needed given that Nakamoto is now enabled on regular testnet

markmhendrickson commented 4 months ago

Reopening since users are getting directed to the special Nakamoto testnet again

314159265359879 commented 4 months ago

related discussion here https://trustmachines.slack.com/archives/C0520G8J33M/p1714555517502539?thread_ts=1714488277.567389&cid=C0520G8J33M

@edgarkhanzadian when do you expect to cover this?

markmhendrickson commented 3 weeks ago

@edgarkhanzadian was this resolved? I'm seeing the regular testnet linked in the explorer instead of custom ones when used in the app:

https://github.com/user-attachments/assets/51e11f0f-d98c-490d-a3d5-86eba22e76d6