leather-io / extension

Leather browser extension
https://leather.io
MIT License
294 stars 141 forks source link

Adding custom testnet with stacks details, defaults with mainnet details for bitcoin API's #5228

Closed 314159265359879 closed 1 month ago

314159265359879 commented 6 months ago

image

A dropdown menu button is shown but no way to select anything else. I am not sure if this should have been released without the testnet option there too.

314159265359879 commented 6 months ago

image

pete-watters commented 3 months ago

Hi @314159265359879 ,

Can you please check this is still an issue? I think it could have been fixed by https://github.com/leather-io/extension/issues/5132.

Either that or I amn't understanding the problem. I added a new Stacks network and I am able to change the Bitcoin network

https://github.com/leather-io/extension/assets/2938440/b7cac1dc-77f3-4d4a-9669-0b0b27a3d886

markmhendrickson commented 2 months ago

cc @314159265359879 for when you can confirm

markmhendrickson commented 2 months ago

nudge @314159265359879

314159265359879 commented 1 month ago

This is a non-issue with fix you named. And if anyone does default to the mainnet API for bitcoin while looking at a Stacks testnet, they can easily change it after this addition: https://github.com/leather-io/extension/issues/5124#issuecomment-2021019201