search

leather-io / extension

Leather browser extension
https://leather.io
MIT License
294 stars 142 forks source link

Wallet with over 400 accounts, started reloading all BNS names and balances #5257

Open 314159265359879 opened 6 months ago

314159265359879 commented 6 months ago

Possible reproduction steps (haven't tried again yet):

  1. Sign in to wallet with 400 accounts and BNS names
  2. Scroll over the account selection screen to load all the names, throttling will cause this to halt from time to time, wait and then scroll further.
  3. Priority is given to BNS names, loading balances takes longer, scroll over again slowly.
  4. I left the wallet alone a while a couple hours later I returned and the full screen tab had crashed showing only a blank page.

Names are balances were no longer cached and it started loading all the names again.

Some other notable things It looks like BNS names are being checked when Stacks is not connected (using ledger device) It looks like addresses with no name, are rechecked every time you scroll over them.

I think names should be persisted on the account selection screen. Names only have to be updated when you enter an account. Account number/name from one account should never be displayed (even temporarily) on another. https://github.com/leather-wallet/extension/issues/5252

markmhendrickson commented 3 months ago

@alter-eggo should we move this issue into WIP, assuming your current client-side throttling work helps to address it? Or will it require separate work?

alter-eggo commented 3 months ago

@markmhendrickson I'm working on a little bit diff things. this should remain in backlog for now

markmhendrickson commented 3 months ago

@314159265359879 have you seen this happen again?

314159265359879 commented 1 week ago

Yes I still see this happening.