leather-io / extension

Leather browser extension
https://leather.io
MIT License
295 stars 141 forks source link

Return `txid` when broadcasting PSBT #5292

Open kyranjamie opened 5 months ago

kyranjamie commented 5 months ago

Currently, regardless of whether the broadcast flag is true or false, we return the PSBT hex in all cases.

Developers broadcasting PSBTs almost always need to know the txid.

In the case of broadcast: true, we should delay the response to the page until the transaction has broadcast successfully.

So:

This should be typed as a discriminating boolean literal in @leather-wallet/types

kyranjamie commented 3 months ago

This has been requested by the Hermetica team

markmhendrickson commented 3 months ago

I presume we can label this effort small?