search

leather-io / extension

Leather browser extension
https://leather.io
MIT License
305 stars 144 forks source link

Switch network, list sometimes takes more time to load, can't select different network until loaded #5453

Open 314159265359879 opened 5 months ago

314159265359879 commented 5 months ago

Steps to reproduce

  1. Open wallet with 50 or so accounts
  2. Switch account scroll over, the accounts let them load
  3. Then when the wallet is throttling
  4. Click top right corner menu
  5. Switch network
  6. See issue: network isn't clickable until the clouds disappear

https://github.com/leather-wallet/extension/assets/33360391/bf2a64d8-408b-4c7c-b828-e3fa461c86a3

Users don't expect to have to wait for this. Is this related to the wallet throttling? I do not see any connection issues in the console when selecting "switch networks".

On a fresh wallet, with one account, clicking switch network, loads them very quickly less then a second before the clouds go away and they are selectable.

markmhendrickson commented 5 months ago

@alter-eggo any idea if this is related to client-side throttling?

alter-eggo commented 5 months ago

@markmhendrickson yes, this is throttling problem, need to put higher priority for request that check network availability

314159265359879 commented 4 months ago

With the throttling improvements in https://github.com/leather-io/extension/pull/5636 it is still possible you have to wait up to 1 minute for the network to be clickable.

markmhendrickson commented 4 months ago

@alter-eggo is there addition work we can do for this issue to make the selection of a network immediate, even if other queries are still pending resolution?

alter-eggo commented 4 months ago

@markmhendrickson I'll check