search

leather-io / extension

Leather browser extension
https://leather.io
MIT License
287 stars 135 forks source link

Users can't connect to dapp or it takes forever #5509

Open 314159265359879 opened 3 weeks ago

314159265359879 commented 3 weeks ago

This issue is unresolved https://github.com/leather-wallet/extension/issues/5021

I see these errors but I am not sure if they are related. It his happening on all dapps. When account data isn't fully loaded yet. It takes forever even when the balance is loaded. This happening especially in wallets with 20 or more accounts and when for example the account balance is still being loaded. I have also seen the same issue (connection to dapp doesn't complete) when balance was just loaded.

Steps to reproduce

  1. Restore Leather with an existing Secret Key that has 20 or more accounts in it.
  2. Click connect on app.alexlab.co or stacks.gamma.io or any other dapp
  3. Scroll down until you see all the "loading" animations for balance
  4. Click one of the accounts with the accounts to connect
  5. spinning (to connect) starts and never stops... dapps never connects image

Possibly unrelated console errors image

Workarounds

314159265359879 commented 3 weeks ago

It looks like users can't switch to different accounts within Leather either because there is loading or throttling going on.

In the above example the wallet is stuck when scrolling over to connect to a specific account on a dapp.

The video displays another issue, that is reproducible with these steps:

  1. being on the last account in a wallet, something in the 400 range
  2. Scrolling all the way up to account 1 (why is there no scroll bar?)
  3. Selecting account 1, clicking it a couple times in the hope of working around the issue... doesn't work
  4. click outside the wallet so the modal closes
  5. try to open it again... doesn't work
  6. Here the extension icon in the browser is clicked and nothing happens (Brave, wallet version 6.42.0):

https://github.com/leather-wallet/extension/assets/33360391/e3b5554a-3a6b-46e8-b4df-b5cd46f1bbf3

markmhendrickson commented 2 weeks ago

@alter-eggo this is quite high priority and presumably related to client-side throttling?

alter-eggo commented 1 week ago

@markmhendrickson yes, seems so, will take a look