leather-io / extension

Leather browser extension
https://leather.io
MIT License
294 stars 142 forks source link

Retesting stackingDAO with Ledger device #5864

Open 314159265359879 opened 3 weeks ago

314159265359879 commented 3 weeks ago

5115 got a little messy trying to cover seamingly related issues that are different.

They look similar because the same error is thrown but the error is very general and can mean many things. They have to be investigated on a case by case basis. "...Ledger has rejected the payload".

With 0.24.2 of the Stacks App on a Ledger Nano S+ with firmware version 1.1.2 You can connect wallet on app.stackingdao.com, reproduction steps:

  1. Use Leather with Ledger device, have Stacks connected and device unlocked with Stacks app on.
  2. Go to app.stackingdao.com
  3. Click connect wallet
  4. Select account
  5. Click Connect Stacks
  6. you are connected without issue.

If you try to sign a transaction to stack STX (convert to stSTX) that will fail. Due to a known issue with 0.42.2 which is being investigated, we hope to see a solution live soon expected with version 0.24.5 or higher of the Stacks app. https://github.com/Zondax/ledger-stacks/issues/171

Using version 0.23.3 (the previous stable version of the Stacks app) and firmware version 1.1.1 on Nano S+ does allow you to sign the arbitrary message to connect and then Stack STX. Signing and broadcasting the transactions works without issue in that case.

I am not sure where the previously reported issue popped up. I am not seeing it with the old versions. Lets wait for 171 to be resolved by Zondax/Ledger and then revisit this.

314159265359879 commented 3 weeks ago

The issue mentioned here: https://github.com/leather-io/extension/issues/5115#issuecomment-2088717168 Using this page https://app.stackingdao.com/signer?pool=SP4SZE494VC2YC5JYG7AYFQ44F5Q4PYV7DVMDPBG.stacking-pool-v1 to commit signature wil lead to the "your ledger device has rejected the payload stating it is invalid"

❌ 0.23.3 and firmware version 1.1.1 with Ledger Nano S+ image

0.24.2 and firmware version 1.1.2 with Ledger Nano S+ ✅ This issue is resolved you can sign all the messages and contract calls

I assume this was resolved by the fix for #2725