feat: wallet settings - Githubissues

leather-io / mono

Leather monorepo

https://leather.io

MIT License

11 stars 5 forks source link

feat: wallet settings #387

Closed edgarkhanzadian closed 2 months ago

edgarkhanzadian commented 2 months ago

Add wallets settings screen
Add Wallet config screen
Add Account config screen
Add account rename functionality
Add account hide functionality
Add wallet rename functionality
Add wallet delete functionality
Add wallet view secret key functionality
Add view hidden accounts screen

https://github.com/user-attachments/assets/8ce83449-a6ef-40c3-85d1-329706290e6f

fbwoolf commented 2 months ago

@edgarkhanzadian now working with this code, wouldn't it make more sense to start nesting the routes based on the flows. For example, /wallet/settings/wallets-and-accounts rather than /wallet/settings/wallet-settings. Or, is that not how things are typ done in mobile? I was trying to add off settings /wallet/settings/display, it seems strange to add /wallet/settings/display-settings as a new folder?

fbwoolf commented 2 months ago

Like this...

edgarkhanzadian commented 2 months ago

@fbwoolf yeap totally agree on changing the folder structure, i also think we should remove the /waiting-list folder s.t. we would not prefix everything with /wallet . I didn't think much of it when the app was small, but yea we def need to pay more attention to it.