Closed tigranpetrossian closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 23.72%. Comparing base (
a8c0c84
) to head (1de23d3
). Report is 1 commits behind head on dev.
This is a good instance of when compound components are great, thanks @tigranpetrossian
I wonder if you'd fancy writing a Coding Convention page on how we should use this pattern (and how we shouldn't).
Definitely! Will get to it during the week.
Great work @tigranpetrossian 👏
Part of LEA-659
Converts the Widget into a Radix-style compound component in preparation for list item animations, but also in an attempt to standardize with other similar components like the Approver
Before
After
This significantly reduces the prop drilling and subsequently the need to expose more props, de-couples it from ScrollView, some spacing opinions (padding, gaps, etc.), and replaces the dependency on
sheet
with a generic action.