search

leavez / cocoapods-binary

integrate pods in form of prebuilt frameworks conveniently, reducing compile time
MIT License
1.31k stars 206 forks source link

Fix bug related to Podfile.lock-only changes #104

Open kylefleming opened 4 years ago

kylefleming commented 4 years ago

CocoaPods-Binary appears to be checking the Podfile against the Manifest.lock to determine if changes occurred and a pod needs to be rebuilt. However, when the version of a pod is changed only in the Podfile.lock (for example, another git user calls pod update and you pull that change), then it appears CocoaPods-Binary doesn't detect the changes.

This PR includes a test case to detect the issue, and fixes it by comparing the Manifest.lock after CocoaPods has done dependency resolution.

Note: This PR is built on top of https://github.com/leavez/cocoapods-binary/pull/103 and https://github.com/leavez/cocoapods-binary/pull/84 since both of those are needed for this PR to pass CI.

TheCoordinator commented 4 years ago

Can we please get this in? Seems good to me.

winstondu commented 4 years ago

This is the fix that this repo needed.