search

leavez / cocoapods-binary

integrate pods in form of prebuilt frameworks conveniently, reducing compile time
MIT License
1.31k stars 206 forks source link

CocoaPods 1.6.0 or above are not supported for resource-containing static frameworks #50

Open ikesyo opened 5 years ago

ikesyo commented 5 years ago

I got an error when running with CocoaPods 1.7.0.beta.2:

TypeError - no implicit conversion of Array into String
/usr/local/lib/ruby/gems/2.6.0/gems/cocoapods-binary-0.4.2/lib/cocoapods-binary/Prebuild.rb:131:in `basename'
/usr/local/lib/ruby/gems/2.6.0/gems/cocoapods-binary-0.4.2/lib/cocoapods-binary/Prebuild.rb:131:in `block (2 levels) in prebuild_frameworks!'
/usr/local/lib/ruby/gems/2.6.0/gems/cocoapods-binary-0.4.2/lib/cocoapods-binary/Prebuild.rb:129:in `each'
/usr/local/lib/ruby/gems/2.6.0/gems/cocoapods-binary-0.4.2/lib/cocoapods-binary/Prebuild.rb:129:in `map'
/usr/local/lib/ruby/gems/2.6.0/gems/cocoapods-binary-0.4.2/lib/cocoapods-binary/Prebuild.rb:129:in `block in prebuild_frameworks!'
/usr/local/lib/ruby/gems/2.6.0/gems/cocoapods-binary-0.4.2/lib/cocoapods-binary/Prebuild.rb:118:in `each'
/usr/local/lib/ruby/gems/2.6.0/gems/cocoapods-binary-0.4.2/lib/cocoapods-binary/Prebuild.rb:118:in `prebuild_frameworks!'
/usr/local/lib/ruby/gems/2.6.0/gems/cocoapods-binary-0.4.2/lib/cocoapods-binary/Prebuild.rb:206:in `block in <class:Installer>'

Looks like this is due to the change for Pod::PodTarget#resource_paths

Could you take a look? Thanks in advance!

ikesyo commented 5 years ago

@leavez Thanks for the quick fix! 💖

leavez commented 5 years ago

I found there's a change in copying resource files for static framework in cocoapods 1.7.

When building a pod with 'static_framework = true' and with cocoapods 1.6, it will generate a framework containing the resource files in framework bundle. But when use cocoapods 1.7, no resources will copied to the framework bundle.

This plugin cannot handle the change right not. So It doesn't work in cocoapods 1.7

reuvenlevitsky commented 5 years ago

Hey @leavez , Thanks for your amazing work!

Is there any estimation for a fix for cocoapods 1.7 static frameworks with bundle?

KPR7168 commented 3 years ago

do we have a solution for this yet?

bolee commented 2 years ago

not support resources now?