search

leavez / cocoapods-binary

integrate pods in form of prebuilt frameworks conveniently, reducing compile time
MIT License
1.31k stars 206 forks source link

Shell-escaped the project path that we use for xcodebuild and lipo. #89

Open antonino-u opened 5 years ago

antonino-u commented 5 years ago

Resolves issue #88. Shellwords is built into Ruby, see the doc for what it does here: https://ruby-doc.org/stdlib-2.0.0//libdoc/shellwords/rdoc/Shellwords.html

In short, a path string like /hello world' becomes suitably escaped for shell use, and transformed into/hello\ world`.

.shellescape was added to string variables passed to both xcodebuild and lipo, and now things work as expected when there are characters (like spaces) that need to be escaped in the file paths.

antonino-u commented 5 years ago

Please Note: the failing build has nothing to do with my change...

MariuszWisniewski commented 4 years ago

I can confirm and reproduce same issue in our project, and can confirm this PR fixes it. Would be great if this PR could be merged @leavez

NathanielBlackburn commented 4 years ago

I can also confirm that it's an issue with projects where the build scheme contains spaces. This PR fixes the problem, please consider merging @leavez

ghost commented 4 years ago

This PR fixes the problem with spaces in build scheme. Please merge it @leavez