search

leavjenn / Hews

A hacker news reader focuses on readng experience with some handy features.
https://leavjenn.github.io/Hews/
MIT License
78 stars 11 forks source link

fixed (shadow): add toolbar shadow for api < 21 #3

Closed brinsche closed 9 years ago

brinsche commented 9 years ago

I noticed that the toolbar doesn’t have a shadow if the device isn’t running lollipop and added a workaround for that. I’m not sure if the added complexity is worth it, I’ll let you decide!

leavjenn commented 9 years ago

Well, maybe that's not a proper UI fix. The stock apps (Messaging, Dial, etc) don't get shadow toolbar on Android before Lollipop, so this may add some inconsistency, and make the code less clean. Still thanks for pulling!