Some DnD errors/crashers

[GoogleCodeExporter]

Playlist View:
--------------

DnD a folder into the left part:

=== STACK TRACE
Traceback (most recent call last):

  File
"/home/xxx/usr/local/lib/python2.6/dist-packages/quodlibet/browsers/playlists.py
",
line 449, in __drag_data_received
    sock = urllib.urlopen(uri)

  File "/usr/lib/python2.6/urllib.py", line 87, in urlopen
    return opener.open(url)

  File "/usr/lib/python2.6/urllib.py", line 203, in open
    return getattr(self, name)(url)

  File "/usr/lib/python2.6/urllib.py", line 461, in open_file
    return self.open_local_file(url)

  File "/usr/lib/python2.6/urllib.py", line 486, in open_local_file
    return addinfourl(open(localname, 'rb'),

IOError: [Errno 21] Is a directory: '/home/xx/drag_folder'

DnD any file/folder into the right part if no playlist is selected:

=== STACK TRACE
Traceback (most recent call last):

  File
"/home/xxx/usr/local/lib/python2.6/dist-packages/quodlibet/qltk/quodlibetwindow.
py",
line 343, in __songlist_drag_data_recv
    if callable(self.browser.reordered): self.browser.reordered(view)

  File
"/home/xxx/usr/local/lib/python2.6/dist-packages/quodlibet/browsers/playlists.py
",
line 567, in reordered
    playlist = Playlist.fromsongs(songs)

  File
"/home/xxx/usr/local/lib/python2.6/dist-packages/quodlibet/browsers/playlists.py
",
line 116, in fromsongs
    {'title': songs[0].comma("title"), 'count': len(songs) - 1})

IndexError: list index out of range

Audio Feed View:
----------------

DnD a wrong file/folder triggers 2 error dialogs.

Original issue reported on code.google.com by reiter.christoph@gmail.com on 17 Mar 2009 at 7:48

[GoogleCodeExporter]

crashers: do some extra checking
double dialog: treeview.set_reorderable() messed up DnD, so 
__drag_data_received got
called 2 times. But reordering isn't implemented so it can be removed for now.

Original comment by reiter.christoph@gmail.com on 17 Mar 2009 at 11:54

Attachments:

• dnd.patch

[GoogleCodeExporter]

Fixes the bugs, doesn't seem to add new ones, passes tests.

Original comment by steven.strobe.cc@gmail.com on 24 Mar 2009 at 1:03

• Added labels: Component-Browser, Patch-Reviewed

[GoogleCodeExporter]

Original comment by steven.strobe.cc@gmail.com on 18 Jun 2009 at 8:23

• Added labels: Milestone-2.0, Patch
• Removed labels: Patch-Reviewed

[GoogleCodeExporter]

This issue was closed by 584f2c8176.

Original comment by steven.strobe.cc@gmail.com on 21 Jun 2009 at 5:44

• Changed state: Fixed