lebauce / quodlibet

Automatically exported from code.google.com/p/quodlibet
1 stars 0 forks source link

#(~b < 2) crashes the search #216

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
#(~b < 2) crashes the search.

Traceback (most recent call last):

  File
"/home/lazka/quodlibet-testing/quodlibet/quodlibet/browsers/search.py",
line 226, in __text_parse
    self.activate()

  File
"/home/lazka/quodlibet-testing/quodlibet/quodlibet/browsers/search.py",
line 209, in activate
    songs = filter(self._filter, self._library.itervalues())

  File "/home/lazka/quodlibet-testing/quodlibet/quodlibet/parse/_match.py",
line 33, in search
    if not re.search(data): return False

  File "/home/lazka/quodlibet-testing/quodlibet/quodlibet/parse/_match.py",
line 95, in search
    num = round(num, 2)

TypeError: a float is required

Original issue reported on code.google.com by reiter.christoph@gmail.com on 4 Jun 2009 at 9:48

GoogleCodeExporter commented 9 years ago

Original comment by steven.strobe.cc@gmail.com on 18 Jun 2009 at 5:25

GoogleCodeExporter commented 9 years ago
Check for numerical types in the final search method..
You can't really tell what type of data will come from the AudioFile dict based 
on
the tag name (see AudioFile.__call__)

Original comment by reiter.christoph@gmail.com on 25 Jun 2009 at 8:24

Attachments:

GoogleCodeExporter commented 9 years ago
This issue was updated by 0213d45302.

The fix is in for 2.0.1, but the root of this problem lies in the fact that
it is possible to receive different types of objects from song.get() depending
on the song being queried. Fixing this may involve behavior changes, and so
will be in a later version.

Original comment by steven.strobe.cc@gmail.com on 28 Jun 2009 at 6:04

GoogleCodeExporter commented 9 years ago

Original comment by steven.strobe.cc@gmail.com on 28 Jun 2009 at 4:23

GoogleCodeExporter commented 9 years ago
Whoops, bumped again.

Original comment by steven.strobe.cc@gmail.com on 21 Jan 2010 at 1:01

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 41cc9d2f03.

Original comment by reiter.christoph@gmail.com on 28 Mar 2010 at 9:44

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Current situation: Everything that starts with ~# and has a numeric default 
returns
an integer.

Original comment by reiter.christoph@gmail.com on 28 Mar 2010 at 9:59