search

lebedev / tabcontrol

A Firefox extension to control tab operations.
https://addons.mozilla.org/firefox/addon/tab-control/
GNU General Public License v2.0
7 stars 2 forks source link

Compatibility with Tab Groups add-on #14

Closed Quicksaver closed 8 years ago

Quicksaver commented 8 years ago

See https://github.com/Quicksaver/Tab-Groups/issues/85 for a description of the bug.

I've already fixed it within Tab Groups, but I'm letting you know about this anyway in case you'd like to integrate it in Tab Control. Basically gTabControl.onTabClose should no-op if closing a tab while in groups mode: https://github.com/Quicksaver/Tab-Groups/commit/91d180846ab65d4f008f035979dbb2a48c48fd8b

lebedev commented 8 years ago

I'll look into it, thanks.

lebedev commented 8 years ago

@Quicksaver, is and will be window.TabView.isVisible() a relying method to detect if groups mode is active?

Quicksaver commented 8 years ago

At least as far as my add-on is concerned yeah. With the add-on enabled, window will always have a TabView property and its isVisible().

lebedev commented 8 years ago

Now we wait until version 0.7.8.2 is reviewed on AMO, so I guess your fix in tabgroups@quicksaver would be an overkill.