search

lebrice / SimpleParsing

Simple, Elegant, Typed Argument Parsing with argparse
MIT License
399 stars 49 forks source link

Include requirements.txt #128

Closed thewchan closed 2 years ago

thewchan commented 2 years ago

Currently requirements.txt is not included in the sdist, which causes setup.py to fail during building downstream in conda forge

lebrice commented 2 years ago

Hey there @thewchan, thanks for this PR!

which causes setup.py to fail during building downstream in conda forge

Interesting! I'd be curious, would you mind elaborating a little bit? Apologies for the question, since I don't know much about Conda packaging, but are you building simple-parsing through Conda somehow? Or just pip-installing it inside a conda environment?

thewchan commented 2 years ago

@lebrice Sure thing! I'm maintaining simple parsing on the conda-forge repo; it basically fetch the sdist from pypi, and run setup.py to build the package, because of that, it needs all the required file in the sdist bundle. E.g., setup.py reads readme.md in one of the steps, which works fine since readme.md is present in the sdist file bundle on PyPI.