search

lebrice / SimpleParsing

Simple, Elegant, Typed Argument Parsing with argparse
MIT License
386 stars 47 forks source link

Fix subgroups with default_factory #188

Closed zhiruiluo closed 1 year ago

zhiruiluo commented 1 year ago

This fix is related to the issue #187.

lebrice commented 1 year ago

Hey there @zhiruiluo, thanks for the PR, but I wouldn't touch subgroups too much if I were you. I'm currently rewriting the feature from the ground-up in #185 .

I'll add the changes you mentioned here in there. Thanks!

zhiruiluo commented 1 year ago

Hey there @zhiruiluo, thanks for the PR, but I wouldn't touch subgroups too much if I were you. I'm currently rewriting the feature from the ground-up in #185 .

I'll add the changes you mentioned here in there. Thanks!

All right. I am closing this PR for now. The fix of default_factory is mainly to make subgroups compatible with Python 3.11.