PEP 561 compliancy - Githubissues

lebrice / SimpleParsing

Simple, Elegant, Typed Argument Parsing with argparse

MIT License

401 stars 50 forks source link

PEP 561 compliancy #74

Closed mixilchenko closed 3 years ago

mixilchenko commented 3 years ago

mypy says: "Skipping analyzing simple_parsing: found module but no type hints or library stubs" SimpleParsing is almost fully typed package therefore it's easy to make it PEP 561 compliant

add py.typed file into package_data

mypy fails with typing.overload and functools.singledispatch usage

refactored simple_parsing.helpers.serialization.encoding.encode typing with
- Dataclass protocol
- primitive types
- collections
commented out encode overloading with comments about mypy errors

mixilchenko commented 3 years ago

Should I update version in setup.py?

lebrice commented 3 years ago

Hey there @mixilchenko , thanks a lot for this! I'll take a look at this soon. No I wouldn't increment the version if I were you, I'll update it and push a new tag to Master once this PR is merged.

Thanks again!

mixilchenko commented 3 years ago

Verified my commits