search

lecle / aloxide

Aloxide is a pragmatic abstraction layer for various blockchain softwares.
Apache License 2.0
10 stars 5 forks source link

feat/#8-write-data-type-between-ledgers #53

Closed danielvo11 closed 4 years ago

danielvo11 commented 4 years ago
Data type EOS ICON
boolean bool bool
number double int
uint64 uint64_t int
uint32 uint32_t int
uint16 uint32_t int
string string string
account name Address
quocle108 commented 4 years ago

Should change address to account in abstract class for easy understand

manh-vv commented 4 years ago

It looks great thank @danielAlvess. Since this MR is going to make a huge conflict with #44, I prefer to review and merge #44 first.

manh-vv commented 4 years ago

@danielAlvess

I don't think we have to introduce new names for the data type. https://github.com/lecle/aloxide/pull/53#issue-482481642. Since data type in EOS can be considered as a superset of data type in ICON, we can use names of data types in EOS in our yaml file. For example:

Data type EOS ICON
bool bool bool
string string string
number uint64_t int
uint64_t uint64_t int
uint32_t uint32_t int
uint16_t uint16_t int
account name Address

It is ok with number but please keep the default of number in EOS to be uint_64.

manh-vv commented 4 years ago

Agreed that the default value of number is double.