search

leclercb / taskunifier-app

TaskUnifier - Task Management Application
https://www.taskunifier.app
Other
27 stars 7 forks source link

↓/↑ don't change current task #80

Closed szpak closed 4 years ago

szpak commented 4 years ago

Describe the bug I would expect to have the up and down arrows to navigate through the tasks in the task grid/table. However, it seems to scroll the table up and down. What's funny that scrolling stops working once the task becomes invisible (or precisely a key press later)

To reproduce Steps to reproduce the behavior:

  1. Show list of tasks with vertical scrolling
  2. Click on any task
  3. Press ↓/↑ multiple times trying to move on to the next/previous task
  4. The task selection doesn't change, the table is scrolling (at least for a moment)

Expected behavior It is possible to change the currently selected task using the up/down arrows (to be able to edit/modify it - in the future)

Version & system information App: 0.8.2 (5da33bd)

Additional context Scrolling with a keyboard shortcut is ok, but it should be rather CTRL-↓/↑.

szpak commented 4 years ago

Thanks. I tested it with 51fb90e, but it works. However, I've encountered the same problem I had reported somewhere with scrolling.

  1. Open a table with 100+ tasks.
  2. Click the first one.
  3. Scroll down to make the originally selected task invisible (to be out of the visual part of the table)
  4. Scroll down more.
  5. Scrolling stops after a few items.

It's enough to click the current task and scrolling works fine (with the limitations mentioned above).

I don't know how Electron implements it, but for instance in Android, not all elements in the (large) scrolling are created, but the reference to the visible one is reused on scrolling. Maybe it's the same issue in Electron?

leclercb commented 4 years ago

Yes, I'm using a virtualized table and it's has some limitations. For the moment I will leave this as is, it's not perfect, but it works... most of the time.

szpak commented 4 years ago

After switch to a grid it seems to be fixed.

szpak commented 4 years ago

Btw, I wonder if it is a feature of that grid to introduce a visible delay on changing elements with a keyboard or there is some extra logic on the TU side which has to be performed? Nevertheless, it's not a big issue, just an observation.

leclercb commented 4 years ago

It's a performance issue, not a feature :( The grid solves quite a lot of visual problems but is a bit less optimized.