search

lecopivo / SciLean

Scientific computing in Lean 4
https://lecopivo.github.io/scientific-computing-lean/
Apache License 2.0
327 stars 29 forks source link

Newton Solver #33

Closed Shreyas4991 closed 6 months ago

Shreyas4991 commented 7 months ago

A PR to add the newton raphson method. All work on this solver will be committed to this PR. The idea is to start with a naive solver and refine it.

Shreyas4991 commented 6 months ago

This last commit brought my fork of scilean up-to-date with the commits of the last month.

lecopivo commented 6 months ago

Can you somehow clean up the pull request such that the only changed files are really only the files you changed?

I'm suspecting you have done rebase, doing merge should keep the diff cleaner

Maybe this question is relevant: https://stackoverflow.com/questions/44000096/github-pull-request-displaying-too-many-file-changes

Shreyas4991 commented 6 months ago

I'll try to do that. I think my git setup rebases automatically

Shreyas4991 commented 6 months ago

I repaired this by using git reset --hard <my last commit. Then I did git push --force origin master.