Thanks! - Githubissues

ledaian41 / android_search_news

News article searching application powered by the New York Times Search API.

0 stars 0 forks source link

Thanks! #1

Open dattran2346 opened 7 years ago

dattran2346 commented 7 years ago

Good to see

Clean and nice code
Bundle app into nice package
Putting lot of effort
Cute progress bar

Thing to improve

Consider to put your network code as an util class
Since the filter dialog is quite complicated, consider to extract the code and create new class for it.
Tried your self with Retrolambda from Java8, they are just function pointer
Have you ever heard of Reactive Programming, a very common usage of them is to reactive response to query change (i.e SearchView), consider to implement a reactive version of SearchView by this

Final word

Congrats on finishing assignment 2. Hope you enjoy the course and learn a lot so far 😸

ledaian41 commented 7 years ago

Thanks for your suggestion. I have learned a lot in this course. I'm going to try to apply reactive response to my app and improve my code.