ledatelescope / bifrost

A stream processing framework for high-throughput applications.

BSD 3-Clause "New" or "Revised" License

66 stars 29 forks source link

complex support for reduce #118

Closed jaycedowell closed 5 years ago

jaycedowell commented 6 years ago

Support for reduce operations on complex types. This also includes reduce operations on the absolute value of the input for both real and complex types.

coveralls commented 6 years ago

Coverage increased (+0.01%) to 61.923% when pulling 8931025286800aa250d97e193dee34e7860ca209 on jaycedowell:master into 8e1c0e13f8ba916ee1fc271943f7a2d0a836e849 on ledatelescope:master.

jaycedowell commented 6 years ago

Docker is unhappy.

codecov-io commented 6 years ago

Codecov Report

Merging #118 into master will decrease coverage by 0.02%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage    58.8%   58.78%   -0.03%     
==========================================
  Files          63       63              
  Lines        5093     5095       +2     
==========================================
  Hits         2995     2995              
- Misses       2098     2100       +2

Impacted Files	Coverage Δ
python/bifrost/reduce.py	`50% <ø> (ø)`	:arrow_up:
python/bifrost/blocks/reduce.py	`23.4% <0%> (-1.05%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e1c0e1...8931025. Read the comment docs.

jaycedowell commented 6 years ago

Dropping gfortran from .travis.yml fixed the build problem and doesn't appear to have broken anything.

jaycedowell commented 5 years ago

Any action on this? I've got a couple of other pool requests in the works that are accidentally contingent on getting this merged in.

jaycedowell commented 5 years ago

Oh yeah, good call. I had forgotten about the blocks.

jaycedowell commented 5 years ago

I don't think there is anything I can do about codecov checks failing because the reduce block runs on the GPU.

telegraphic commented 5 years ago

Well, FWIW I'm happy for this to be merged

telegraphic commented 5 years ago

to add -- the unittest for complex reduce passes when I ran it too

jaycedowell commented 5 years ago

Ok, cool. @benbarsdell any other comments?

jaycedowell commented 5 years ago

No further comments after three weeks, merging.