ledatelescope / bifrost

A stream processing framework for high-throughput applications.

BSD 3-Clause "New" or "Revised" License

66 stars 29 forks source link

Testbench and Tools Modernization #133

Closed jaycedowell closed 4 years ago

jaycedowell commented 5 years ago

Work on modernizing the testbench and tools scripts by converting over to print_function and argparse. Also, added a simple test suite that uses pylint to give the scripts a basic sanity check during testing.

coveralls commented 5 years ago

Coverage decreased (-0.3%) to 61.663% when pulling cfac53de8dda9b0861f37134a5515ca30cc85cbf on argparse into 232974518fe9bd1a22293c2cc236fb5bc46dd6a2 on master.

codecov-io commented 5 years ago

Codecov Report

Merging #133 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   58.78%   58.78%           
=======================================
  Files          63       63           
  Lines        5095     5095           
=======================================
  Hits         2995     2995           
  Misses       2100     2100

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2329745...f6c9312. Read the comment docs.

telegraphic commented 5 years ago

Had a quick (i.e. not comprehensive) look through and think this all looks great. OK to merge IMO

jaycedowell commented 4 years ago

test_scripts.py runs a static analysis of the scripts using pylint to try and find obvious errors. It is not as good as actually running the script with data and comparing the output but I think that it is better than nothing.

telegraphic commented 4 years ago

Ah ok, well still LGTM.

codecov-commenter commented 4 years ago

Codecov Report

Merging #133 into master will decrease coverage by 0.17%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   58.78%   58.61%   -0.18%     
==========================================
  Files          63       64       +1     
  Lines        5095     5110      +15     
==========================================
  Hits         2995     2995              
- Misses       2100     2115      +15

Impacted Files	Coverage Δ
python/bifrost/romein.py	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72e0315...cfac53d. Read the comment docs.

jaycedowell commented 4 years ago

Let's do this!