search

ledatelescope / bifrost

A stream processing framework for high-throughput applications.
BSD 3-Clause "New" or "Revised" License
66 stars 29 forks source link

Unified packet capture interface #145

Closed jaycedowell closed 2 years ago

jaycedowell commented 4 years ago

This PR provides a unified packet capture interface that makes it easier to add new packet formats to Bifrost and to read packet formats from the network (unicast or multicast) or from disk. This also includes a generalization of the packet writer interface. This PR changes the Bifrost API in a couple of ways:

coveralls commented 4 years ago

Coverage Status

Coverage increased (+1.6%) to 63.267% when pulling 4529e9ba2553deb088783e43c4b37f92c9bd7e05 on jaycedowell:disk-readers into b25bfc863bc63e630dd9390dc588a280b78be3d2 on ledatelescope:master.

codecov-commenter commented 4 years ago

Codecov Report

Merging #145 into master will decrease coverage by 1.79%. The diff coverage is 73.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   61.62%   59.82%   -1.80%     
==========================================
  Files          64       64              
  Lines        5300     5374      +74     
==========================================
- Hits         3266     3215      -51     
- Misses       2034     2159     +125
Impacted Files Coverage Δ
python/bifrost/address.py 83.33% <50.00%> (-1.97%) :arrow_down:
python/bifrost/udp_socket.py 77.77% <50.00%> (+20.63%) :arrow_up:
python/bifrost/packet_capture.py 72.30% <72.30%> (ø)
python/bifrost/packet_writer.py 79.54% <79.54%> (ø)
python/bifrost/fir.py 0.00% <0.00%> (-100.00%) :arrow_down:
python/bifrost/romein.py 0.00% <0.00%> (-100.00%) :arrow_down:
python/bifrost/blocks/scrunch.py 37.03% <0.00%> (-59.26%) :arrow_down:
python/bifrost/map.py 20.83% <0.00%> (-56.25%) :arrow_down:
python/bifrost/linalg.py 36.84% <0.00%> (-52.64%) :arrow_down:
python/bifrost/fft.py 45.00% <0.00%> (-50.00%) :arrow_down:
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a53b35b...229de90. Read the comment docs.

codecov-io commented 3 years ago

Codecov Report

Merging #145 (edfe360) into master (e1cea0b) will decrease coverage by 1.71%. The diff coverage is 74.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   61.62%   59.90%   -1.72%     
==========================================
  Files          64       64              
  Lines        5300     5395      +95     
==========================================
- Hits         3266     3232      -34     
- Misses       2034     2163     +129
Impacted Files Coverage Δ
python/bifrost/address.py 83.33% <50.00%> (-1.97%) :arrow_down:
python/bifrost/udp_socket.py 77.77% <50.00%> (+20.63%) :arrow_up:
python/bifrost/packet_capture.py 72.09% <72.09%> (ø)
python/bifrost/packet_writer.py 84.09% <84.09%> (ø)
python/bifrost/fir.py 0.00% <0.00%> (-100.00%) :arrow_down:
python/bifrost/romein.py 0.00% <0.00%> (-100.00%) :arrow_down:
python/bifrost/blocks/scrunch.py 37.03% <0.00%> (-59.26%) :arrow_down:
python/bifrost/map.py 20.83% <0.00%> (-56.25%) :arrow_down:
python/bifrost/linalg.py 36.84% <0.00%> (-52.64%) :arrow_down:
python/bifrost/fft.py 45.00% <0.00%> (-50.00%) :arrow_down:
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1cea0b...edfe360. Read the comment docs.

codecov-commenter commented 3 years ago

Codecov Report

Merging #145 (4529e9b) into master (b25bfc8) will decrease coverage by 1.71%. The diff coverage is 74.63%.

:exclamation: Current head 4529e9b differs from pull request most recent head b482898. Consider uploading reports for the commit b482898 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   61.62%   59.90%   -1.72%     
==========================================
  Files          64       64              
  Lines        5300     5395      +95     
==========================================
- Hits         3266     3232      -34     
- Misses       2034     2163     +129
Impacted Files Coverage Δ
python/bifrost/address.py 83.33% <50.00%> (-1.97%) :arrow_down:
python/bifrost/udp_socket.py 77.77% <50.00%> (+20.63%) :arrow_up:
python/bifrost/packet_capture.py 72.09% <72.09%> (ø)
python/bifrost/packet_writer.py 84.09% <84.09%> (ø)
python/bifrost/fir.py 0.00% <0.00%> (-100.00%) :arrow_down:
python/bifrost/romein.py 0.00% <0.00%> (-100.00%) :arrow_down:
python/bifrost/blocks/scrunch.py 37.03% <0.00%> (-59.26%) :arrow_down:
python/bifrost/map.py 20.83% <0.00%> (-56.25%) :arrow_down:
python/bifrost/linalg.py 36.84% <0.00%> (-52.64%) :arrow_down:
python/bifrost/fft.py 45.00% <0.00%> (-50.00%) :arrow_down:
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b25bfc8...b482898. Read the comment docs.

jaycedowell commented 2 years ago

I'm going to close this and open a new PR using the new ibverb-support branch I created.