Closed jaycedowell closed 6 months ago
Attention: Patch coverage is 95.83333%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 66.94%. Comparing base (
898e4a8
) to head (0bb8c61
). Report is 2 commits behind head on master.:exclamation: Current head 0bb8c61 differs from pull request most recent head 0477754. Consider uploading reports for the commit 0477754 to get more accurate results
Files | Patch % | Lines |
---|---|---|
python/bifrost/ndarray.py | 95.83% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR enables support for the
astype()
method onbifrost.ndarray
's. This was previously disabled because of problems with arrays that were in the "cuda" space. As implmented:numpy.ndarray.astype()
for non-complex integer types. Complex integer types need to be handled separately so that the conversion happens as expected (complex -> real keeps only real; real -> complex only populates real).bifrost.libbifrost._bf.bfMap()
to run the conversion on the GPU. The conversion function is set based on the input and output data types.