search

ledatelescope / bifrost

A stream processing framework for high-throughput applications.
BSD 3-Clause "New" or "Revised" License
66 stars 29 forks source link

Code Pruning #178

Open jaycedowell opened 2 years ago

jaycedowell commented 2 years ago

This PR cleans up the code base by removing unused and commented out code. It may also be an appropriate place to address #156.

codecov-commenter commented 2 years ago

Codecov Report

Merging #178 (e6bed74) into master (317d653) will increase coverage by 9.62%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   58.37%   67.99%   +9.62%     
==========================================
  Files          67       67              
  Lines        5744     7262    +1518     
==========================================
+ Hits         3353     4938    +1585     
+ Misses       2391     2324      -67
Impacted Files Coverage Δ
python/bifrost/ring.py 89.66% <ø> (ø)
python/bifrost/blocks/binary_io.py 93.44% <100.00%> (ø)
python/bifrost/version/__init__.py 100.00% <0.00%> (ø)
python/bifrost/libbifrost_generated.py 72.85% <0.00%> (ø)
python/bifrost/ring2.py 85.71% <0.00%> (+0.25%) :arrow_up:
python/bifrost/pipeline.py 84.87% <0.00%> (+1.17%) :arrow_up:
python/bifrost/DataType.py 66.89% <0.00%> (+2.02%) :arrow_up:
python/bifrost/blocks/transpose.py 96.87% <0.00%> (+3.12%) :arrow_up:
python/bifrost/memory.py 78.94% <0.00%> (+3.50%) :arrow_up:
python/bifrost/ndarray.py 82.93% <0.00%> (+9.78%) :arrow_up:
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 317d653...e6bed74. Read the comment docs.

league commented 2 years ago

I'm looking into the drop in coverage on ring.py. Would to complete/resolve the ring → ring2 replacement/merger with this branch?

jaycedowell commented 2 years ago

I've given up on removing bifrost.block since there seems to be a few knock on consequences to that. bifrost.ring vs bifrost.ring2 might be a similar thing but I think we need to sort out #179 before we try that.

jaycedowell commented 1 year ago

I'm starting to pick this up again. I wonder if this kind of cleanup makes sense to do as part of the no_python2 branch.

jaycedowell commented 1 year ago

This project has migrated over to #216 and the no_python2 branch. apr2022-prune should be removed once #216 is merged.