ledatelescope / bifrost

A stream processing framework for high-throughput applications.
BSD 3-Clause "New" or "Revised" License
66 stars 29 forks source link

Fix for #197 - `Pipeline.as_default()` fails #200

Closed jaycedowell closed 1 year ago

jaycedowell commented 1 year ago

This PR addresses #197 where Pipeline.as_default() throws an error because PipelineContext isn't defined. The fix here updates the thread local storage by adding the new Pipeline instance to the end of list of pipelines and also updates the list of block scopes.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.02 :warning:

Comparison is base (abee49a) 65.40% compared to head (83ab7e6) 65.39%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #200 +/- ## ========================================== - Coverage 65.40% 65.39% -0.02% ========================================== Files 67 67 Lines 5839 5840 +1 ========================================== Hits 3819 3819 - Misses 2020 2021 +1 ``` | [Impacted Files](https://app.codecov.io/gh/ledatelescope/bifrost/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LEDA+Collaboration) | Coverage Δ | | |---|---|---| | [python/bifrost/pipeline.py](https://app.codecov.io/gh/ledatelescope/bifrost/pull/200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LEDA+Collaboration#diff-cHl0aG9uL2JpZnJvc3QvcGlwZWxpbmUucHk=) | `84.70% <0.00%> (-0.17%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.