search

ledatelescope / bifrost

A stream processing framework for high-throughput applications.
BSD 3-Clause "New" or "Revised" License
64 stars 29 forks source link

Update dockerfiles to ubuntu-20.04 and autoconf #215

Open league opened 11 months ago

league commented 11 months ago

The nvidia/cuda:10.2 image disappeared from the hub, so the GPU versions in master were not buildable anymore. Also, the two that build bifrost were not yet using the configure script.

However, the full-build .gpu version doesn't quite work because nvidia-docker seems to provide access to GPU during run phase, but not during build phase. Perhaps relevant: https://stackoverflow.com/questions/59691207/docker-build-with-nvidia-runtime

The _prereq.gpu version builds fully and is still helpful.

Also pinging PR #92 which is outdated but relevant.

codecov[bot] commented 11 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (0bab382) 65.39% compared to head (2c73d15) 65.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #215 +/- ## ======================================= Coverage 65.39% 65.39% ======================================= Files 67 67 Lines 5840 5840 ======================================= Hits 3819 3819 Misses 2021 2021 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jaycedowell commented 11 months ago

Oh look, it's our good friend the "test_matmul_aa_ci8" test failure (#187).

jaycedowell commented 11 months ago

For the build of .gpu could we just specify all supported SMs? And then set a reasonable default for the shared memory per SM? I think those are the only two things that require a working GPU.

jaycedowell commented 11 months ago

Should we turn the docker builds into CI tests? Maybe only in master?

league commented 11 months ago

I'm mixing another idea into this dockerfile PR, but it's minor stuff I encountered about test conditions while figuring out the prereqs in docker.

Re: building with Dockerfile.gpu, yes I think specifying to configure will work, will try. It's similar to what we need with nix because of hermetic build where we can't directly query hardware capabilities.

Re: building docker in CI: I wasn't sure whether docker-build works within docker but I guess it might. May be worthwhile if we want to support these things. (They are still mentioned in the README, and I guess I'm still finding them convenient for testing and playing around.)

jaycedowell commented 11 months ago

Maybe this could help with the docker stuff: https://github.com/marketplace/actions/build-and-push-docker-images

jaycedowell commented 4 months ago

Maybe we should go up to Jammy on this.