Closed league closed 1 year ago
It might be good to pick some of the "safer" things from #178 and add them in here.
Patch coverage: 87.29%
and project coverage change: +2.16%
:tada:
Comparison is base (
becbf48
) 65.39% compared to head (f5b0b02
) 67.56%. Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think all of the clean-ups in #178 are here now, except the ones that are more complicated:
But commits in this PR (or that previously made it to master) include these clean-ups:
…in addition to the Python2 cleanups.
I recall problems when I tried to remove block.py but I don't remember exactly what they were. It's a shame that those logs from #178 have expired and been removed.
When I was working on 8cff5c2 I noticed that there was another Python2-ism buried in test_scripts.py
. There might be other things labeled as "Python2 catch" in the code, specifically related to bytes -> str -> bytes conversion that were missed.
Should we put a "needs Python 3.6+" message somewhere? That's the only thing I can thing of that this might be missing.
Added in b5f503a.
Should we also change configure
to check if Python is >=3.6?
Add in e01355f.
That's everything now.
This was a branch, but I just updated it from master and started a PR to more easily see and discuss changes.
(I was about to delete some
__future__
stuff when I remembered to look for this branch.)